Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission typo: fancyholograms.hologram.line.set #186

Open
Frumple opened this issue Jan 18, 2025 · 0 comments
Open

Permission typo: fancyholograms.hologram.line.set #186

Frumple opened this issue Jan 18, 2025 · 0 comments

Comments

@Frumple
Copy link

Frumple commented Jan 18, 2025

Looking at the pull request that added permissions (https://github.com/FancyMcPlugins/FancyHolograms/pull/153/files#diff-0161952286190f22403af679011845803e6ab28024a5d89dd1782619bcff383eR22), I noticed one of the edit line permissions seems inconsistent with the rest.

For the "addline" and "removeline" commands, the permissions are:

  • fancyholograms.hologram.edit.line.add
  • fancyholograms.hologram.edit.line.remove

But for "setline", the permission is:

  • fancyholograms.hologram.line.set

That permission should be fancyholograms.hologram.edit.line.set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Frumple