Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-minimizing a window always resizes it larger, squishing others. #277

Open
b1scu1t opened this issue Jul 13, 2024 · 4 comments
Open

Un-minimizing a window always resizes it larger, squishing others. #277

b1scu1t opened this issue Jul 13, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@b1scu1t
Copy link

b1scu1t commented Jul 13, 2024

Describe the bug
If two or more windows are tiled and one is minimized and un-minimized, the un-minimized windows will always re-size to be the largest window possible, force the other tiled windows to their minimum size when doing so.

To Reproduce
Steps to reproduce the behavior:

  1. Open two programs (Windows Explorer & Vivaldi/Chrome.
  2. Minimize and Un-Minimize one program (Windows Explorer)
  3. See error

Expected behavior
The two windows are equally split, like FancyWM usually does. Or the minimized window retains its size when un-minimized or focused.

Screenshots

FancyWM_fvdAzZPSRJ.mp4

Desktop (please complete the following information):

  • OS: Windows 10 LTSC 2021
  • OS Build: 19044.4529
  • FancyWM Version: 2.14.0

Additional context
I have attached my settings file here for more insight. I have also reproduced the problem in Windows 11.
settings.json

@AndreasHnida
Copy link

please make this a possiblity to keep the windows original size. It drives me nuts every time I pop up a window from the task bar.

@veselink1 veselink1 self-assigned this Jul 15, 2024
@veselink1 veselink1 added the bug Something isn't working label Jul 15, 2024
@leandrosdornelles
Copy link

I I fixed this issue by modifying the UnregisterAndSaveLocation method in TillingService.private.cs and performed a local build. Here is the adjustment I made to this method:

m_savedLocations[e.Source] = new NodeLocation(window); -- removed this line

By removing the line above, the app treated all windows as new and always recalculates the size needed when unminimizing already opened windows.

Now is behaving perfectly here, I haven't had any more problems.

@AndreasHnida
Copy link

Thank you. Nice one. It's behaving now as expected.

@b1scu1t
Copy link
Author

b1scu1t commented Aug 1, 2024

I I fixed this issue by modifying the UnregisterAndSaveLocation method in TillingService.private.cs and performed a local build. Here is the adjustment I made to this method:

m_savedLocations[e.Source] = new NodeLocation(window); -- removed this line

Tried this, it seems to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants