Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thermal conductivity from BPX schema #50

Open
ejfdickinson opened this issue Nov 20, 2023 · 1 comment
Open

Remove thermal conductivity from BPX schema #50

ejfdickinson opened this issue Nov 20, 2023 · 1 comment

Comments

@ejfdickinson
Copy link
Collaborator

ejfdickinson commented Nov 20, 2023

spotted by @ikorotkin

The BPX schema includes a field ["Parameterisation"]["Cell"]["Thermal conductivity [W.m-1.K-1]"]. However, this parameter is not defined or used in the corresponding mathematical specification for any model.

Proposed fix:

  • remove thermal conductivity from the BPX schema, as it doesn't do anything
  • perhaps update the standard document to indicate that thermal parameterisation such as conductivities can constitute user-defined parameters?
  • can we support backwards-compatibility for old BPX versions in which this field is allowed?

Recommended to fix after v0.4 release.

@rtimms
Copy link
Collaborator

rtimms commented Nov 20, 2023

Thanks! On your points:

  • Agree
  • Agree also
  • Yes, let's handle this as a special case in the next version (we can automatically move it to a suitably named user-defined parameter) with a warning that it will be deprecated in the future (say, by v0.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants