Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Update cython dependency to cython 3 #921

Closed
1 task done
evan0greenup opened this issue Feb 13, 2024 · 4 comments
Closed
1 task done

[Proposal] Update cython dependency to cython 3 #921

evan0greenup opened this issue Feb 13, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@evan0greenup
Copy link

evan0greenup commented Feb 13, 2024

Proposal

Currently, the dependency specifier on cython is cython < 3. It would be good to port gymnasium to cython 3.

Motivation

User whose project need both cython 3 and gymnasium would have problem. And cython 3 fix a lot of bugs.

Checklist

  • I have checked that there is no similar issue in the repo
@evan0greenup evan0greenup added the enhancement New feature or request label Feb 13, 2024
@Kallinteris-Andreas
Copy link
Collaborator

cython<3 to use the old mujoco-py binaries for the v2 and v3 of those requirements, if you are not using them you can safely use cython>=3

@im-Kitsch
Copy link

I think we all admit that mujoco-py and mujoco-series "-v2" environments are annoying and not as good as new version. But the problem is that they are still widely used since the research cummunity still uses mujoco-py frequently for online or offline RL. To validate this, just search RL related paper randomly in this year or check the new issues in mujoco-py repo. To compare with new/old baselines/benchmarks people have to use old "-v2" version.

Moreover, the dependency for cython could be simplely updated by this PR openai/mujoco-py#782. So it would be really really very very appreciated to adjust mujoco-py to cython>3.

I disklike Mujoco-py, it's really annoying but I think many people still have to use it for a long time.

@pseudo-rnd-thoughts
Copy link
Member

Mujoco-py is hosted and maintained by OpenAI, not Farama, therefore, there is nothing that we can do to apply the PR you link above.
We understand your annoyance with v2 and plan to remove them in the future but this isn't a problem and if you don't download gymnasium[mujoco-py] then this issue shouldn't effect you

@pseudo-rnd-thoughts
Copy link
Member

Only "gymnasium[mujoco-py]" is limited to cython < 3, therefore, for users needing cython 3 then they cannot use mujoco-py (from pypi) or must build from source with the linked solution.
Therefore, closing as not a gymnasium issue

@pseudo-rnd-thoughts pseudo-rnd-thoughts closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants