Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number tests #38

Closed
wants to merge 1 commit into from
Closed

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Aug 4, 2023

  • relates to conversation starting at [json-org] fix issue with parsing big numbers #32 (comment)
  • the number behaviour changed in v2.15.0
  • both jsr-353 and json-org provide getters on their Json Value APIs that allow users to choose what number format they want - users have this control
  • users who insist on using the APIs that return java.lang.Number will see differences after v2.15. They get a BigDecimal instead of a double. This is a little unfortunate but the changes help users who need us to retain the precision of big numbers.
  • I would prefer not to make big changes and not to revert the 2.15 changes. I think it is better to play it by ear - to see just how many people complain and get their reasons why they can't make small changes to their own code to react to the jackson change.

@cowtowncoder
Copy link
Member

Obsoleted by #40, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants