Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cdt.data.load_dataset('sachs') + one of the returned objects, 'target', is inconsistent with the paper(Sachs,etc 2005) #143

Open
xwbxxx opened this issue Sep 17, 2022 · 1 comment

Comments

@xwbxxx
Copy link

xwbxxx commented Sep 17, 2022

The CDT version is 0.6.0 (as you can see in the first line of the output)

Problem: When I viewed the target, I found there exists a loop among PIP2, PIP3 and plcg(The top 3 nodes in my screenshot).
image

As far as I know, Sachs Dataset should be a DAG, so I checked the paper where the graph came from, Causal-Protein-Signaling-Networks-Derived-from-Multiparameter-Single-Cell-Data(Sachs,etc 2005) to make sure.
According to the paper, PIP3 should point to PIP2 . Moreover, there are a total of 20 edges in the diagram of the paper, but the function, cdt.data.load_dataset('sachs'), outputs a graph with only 18 edges. So I would like to know if the Sachs dataset is updated or if there are errors and missing edges in the graph from this function.

image

@diviyank
Copy link
Collaborator

Hello ! Thanks for the feedback ! I know that this dataset does have multiple versions (and revisions) ; I'll check and get back to you ! My version could be out-of-date

Best,
Diviyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants