-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to clear require() function's cache #243
Comments
Instead of bugging the devs to impliment a feature that bypasses your script issues, why not just fix your script so it works? |
What I mean is, |
About a week ago I made a simplified version of my avatar public (https://github.com/AceKiron/A). It logs |
I downloaded your avatar and cannot reproduce your issue. What exactly do you mean by I have a feeling that you think that If you still believe that figura is at fault for this, please provide video proof of just figura with no other mods and state the figura version and minecraft version. I need to see you uploading your test avatar in single player, exiting to menu, going back to the single player world. Then exit and join the server, waiting for your avatar to load. You will need to remove the mod check and use a different server for testing, as this test requires just figura. Below is me doing just that, using my own ip as a test and removing the mod check. The only change made is line 1 of 2024-07-22.15-46-17.mp4 |
Clearing the |
That's.. unexpected. That avatar didn't work on my PC at home.
A lack of my avatar being reloaded is what's the problem here.
I'll do that once I come back home. |
I'm using Minecraft/FabricMC version fabric-loader-0.15.6-1.20.4, and Figura version figura-0.1.4+1.20.4-fabric-mc. Other than that I don't have any mods installed currently. The plugins\sample\index.lua:1 line was changed to The video was too big for me to upload on GitHub, so I uploaded it to YouTube instead: https://youtu.be/WS04fxiT5Ws. |
Testing shows that the script does in fact run over the print statement but just doesn't print anything After more testing, I have no idea why the print isn't working. As far as I can tell, Figura should print the message as soon as it is available to. Yet it doesn't. |
Found the issue. 1.20.4 is not reloading the player at all between world loads. I think vanilla is doing some "optimizations" by keeping the Player entity in memory instead of creating a new instance. Figura only triggers the reload when a new instance is created. Below video showcases this issue. Top left os 1.20.1, bottom right is 1.20.4. Expected behavior is when exiting to menu and rejoining the world, the player is reinitialized. This is showcased by the other minecraft instance uploading a different avatar. However, when 1.20.4 exits and rejoins the world, the avatar persists through the world transfer. Initialization scripts are not executed. Major bug plz fix 2024-07-26.17-51-53.mp4 |
Can someone else figure out which versions of minecraft this occurs on? 1.20.1 has expected results, 1.20.4 does not. Still need to check 1.20.6 and 1.21 the following avatar was used to check: |
Reproduced on 1.21 (same bug as you experienced in 1.20.4). i lack a 1.20.6 instance but its probably safe to assume its a bug on 1.20.4+ |
Request Description
Currently I have to manually reload my avatar (go into third person, hold R, then select Reload Avatar) in order to fix an issue caused by the fact the require() function is cached.
Could we get a feature that either clears the function's cache, disables its cache altogether, or a second require() function that doesn't cache?
The text was updated successfully, but these errors were encountered: