Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work_Item] Clarify definition of SKU ID #314

Open
flanakin opened this issue Jan 27, 2024 · 16 comments · May be fixed by #676
Open

[Work_Item] Clarify definition of SKU ID #314

flanakin opened this issue Jan 27, 2024 · 16 comments · May be fixed by #676
Assignees
Labels
1.2 Agreed scope for release 1.2 csp Cloud service providers sku details Attributes related to the SKU entity spec revision Revise existing definition to be clearer or more accurate work item Issues to be considered for spec development
Milestone

Comments

@flanakin
Copy link
Contributor

flanakin commented Jan 27, 2024

1. Problem Statement *

Describe the problem, issue, use case, or opportunity that this work item addresses.
Include practitioner quotes illustrating real examples a) of questions being asked by practitioners and b) value unlocked by answering these questions, if available.

  • What is the problem?: Explain the context and why it needs resolution.
  • Impact: Describe how the problem affects users, systems, or the project.

As a provider, I don't know what value to use for SkuId. The description is not explicit enough in what the value represents. Given there are many attributes for a SKU that make it unique, the description needs to be more precise so providers know what value to use and practitioners can reliably depend on the value across providers.

Use cases:

  • Identifying the highest-level product that is being charged for.
  • Evaluating potential SKUs for potential commitment discount savings.

2. Objective *

State the objective of this work item. What outcome is expected?

  • Success Criteria: Define how success will be measured (e.g. metrics and KPIs).

Clearly describe what SkuId represents so it's clear to implementers.

3. Supporting Documentation *

Include links to supporting documents such as:

  • Data Examples: [Link to data or relevant files; DO NOT share proprietary information]
  • Related Use Cases or Discussion Documents: [Link to discussion]
  • PRs or Other References: [Link to relevant references]

Current description:

A SKU ID is an unique identifier that defines a provider-supported construct for organizing properties that are common across one or more SKU Prices. SKU ID can be referenced on a catalog or price list published by a provider to look up detailed information about the SKU. The composition of the properties associated with the SKU ID may differ across providers. Some providers may not support the SKU construct and instead associate all such properties directly with the SKU Price. SKU ID is commonly used for analyzing cost based on SKU related properties above the pricing constructs.

https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/blob/working_draft/specification/columns/skuid.md

4. Proposed Solution / Approach

Outline any proposed solutions, approaches, or potential paths forward. Do not submit detailed solutions; please keep suggestions high-level.

  • Initial Ideas: Describe potential solution paths, tools, or technologies.
  • Considerations: Include any constraints, dependencies, or risks.
  • Feasibility: Include any information that helps quantify feasibility, such as perceived level of effort to augment the spec, or existing fields in current data generator exports.
  • Benchmarks: Are there established best practices for solving this problem available to practitioners today (e.g. mappings from existing CSP exports that are widely used)?

Needs discussion as it's never been clear what this represents.

I would like to see this mapped back to existing retail product thinking rather than trying to define something on our own. @kk09v mentioned this in a previous meeting.

5. Epic or Theme Association

This section will be completed by the Maintainers.

  • Epic: [Epic Name]
  • Theme: [Theme Name, if applicable]

TBD

6. Stakeholders *

List the main stakeholders for this issue.

  • Primary Stakeholder: [Name/Role]
  • Other Involved Parties: [Names/Roles]
  • Primary stakeholder: Michael Flanakin, Product Manager

Do you want to see this column in FOCUS?

Give it a 👍 below ↴

Comments are welcome and encouraged!

@ijurica
Copy link
Contributor

ijurica commented Jan 29, 2024

Questions:

  • SkuPriceId should reference the relevant published ListUnitPrice, and in cases with multiple tiers, it should correspond to the price associated with a specific tier, right?
  • We've also established that SkuId MUST match SkuPriceId when a provider lacks an overarching SKU ID construct. What if a provider does support both SKU and SKU Price?, what additional properties, besides tier, should be associated with SKU Price rather than SKU?
  • Do we plan to specify/impose that list of properties associated to the SKU Price and not SKU level. If the answer is yes and if a Provider can't provide SKU which is compliant with that, they should simply provide the same value for both SkuPriceId and SkuId or what?

@marc-perreaut
Copy link
Contributor

marc-perreaut commented Jan 30, 2024

I believe providers should define SKUs as different types of usage, meaningful from a DevOps perspective (i.e. can be monitored), to which additional dimensions might be added to define the price, like Tier and PricingCategory.
Maybe for Azure, SkuId could the combination of Azure MeterSubCategory and Meter, and SkuPriceId could be the combination of Azure PartNumber and PricingModel (would need to check the relationship diagram between them).

@flanakin
Copy link
Contributor Author

The problem I have is that I don't know what a "SKU" is for FOCUS. It's not clear as a provider what I should set the value to. And if I don't know, I'm pretty sure others won't either. At best, everyone will guess and we'll end up with inconsistent meanings for SkuId, which will make it meaningless. I don't think we need to require that SkuId have a specific set of attributes, but I do think we should say what it SHOULD include to make it clear what the intent is. As of right now, I could put absolutely anything in there and abide by the spec. That feels broken.

@flanakin flanakin self-assigned this Jan 31, 2024
@github-project-automation github-project-automation bot moved this to Triage in FOCUS WG Feb 13, 2024
@jpradocueva jpradocueva moved this from Triage to Parking Lot in FOCUS WG Feb 13, 2024
@jpradocueva jpradocueva added this to the v1.x milestone Feb 29, 2024
@flanakin
Copy link
Contributor Author

flanakin commented Mar 3, 2024

I feel this should be part of 1.0. Right now, it's not clear what value should be used for SkuId. Am I the only one?

@flanakin flanakin changed the title [Proposal] SkuId is not clear SkuId is not clear Mar 3, 2024
@marc-perreaut
Copy link
Contributor

I agree that SKU ID must be part of 1.0 and that its description as "a unique identifier that defines a provider-supported construct for organizing properties that are common across one or more SKU Prices" is somewhat abstract.

The description of a SKU Price ID as "a unique identifier that defines the unit price used to calculate the charge" might also seem awkward, as the term SKU is part of the name, but not of the description.

From the discussions that led to the current specification version, I understand that a SKU in FOCUS is in simple words what is purchased or used by a consumer, and what is charged to the consumer. This has been split in FOCUS into SKU ID (to identify the SKU) and into SKU Price ID (to identify the unit price), because a single SKU may have multiple prices, depending on other dimensions like Pricing Tier for example. Is it correct? If yes, I would propose indeed to reformulate the descriptions of SKU ID and SKU Price ID to link them more clearly to the core concept of SKU.

@jpradocueva
Copy link
Contributor

Action Items:

  • TS2-#313-#314: Michael: To provide a list of SKU attributes and further expand on what constitutes a SKU ID.
  • TS2-#313-#314: All Members: To prepare for a detailed discussion on SKU attributes and categorization next week.

@jpradocueva jpradocueva moved this from Parking Lot to W.I.P in FOCUS WG Jun 26, 2024
@shawnalpay shawnalpay added discussion topic Item or question to be discussed by the community spec revision Revise existing definition to be clearer or more accurate labels Oct 8, 2024
@jpradocueva jpradocueva removed the P1 label Oct 9, 2024
@flanakin flanakin added the 1.2 consideration To be considered for release 1.2 label Oct 16, 2024
@ijurica ijurica self-assigned this Oct 17, 2024
@shawnalpay shawnalpay added the needs work item Needs an issue that adheres to the Work Item issue template, prior to consideration by stakeholders label Oct 22, 2024
@flanakin flanakin changed the title SkuId is not clear [WORK_ITEM] SkuId is not clear Oct 22, 2024
@flanakin flanakin removed the discussion topic Item or question to be discussed by the community label Oct 22, 2024
@shawnalpay shawnalpay changed the title [WORK_ITEM] SkuId is not clear [Work_Item] SkuId is not clear Oct 24, 2024
@shawnalpay shawnalpay changed the title [Work_Item] SkuId is not clear [Work_Item] Clarify definition of SKU ID Oct 24, 2024
@shawnalpay shawnalpay added the csp Cloud service providers label Oct 29, 2024
@smokemonster99
Copy link

As a practitioner, it is not immediately apparent to me that I would care too much about the actual SKU ID value and I could handle cross provider uniqueness by joining with Provider; however if providers can create SKU ID as something meaningful I am all for that.

@jpradocueva
Copy link
Contributor

Notes from Maintainers' call on November 4:

Context: The term “SKU ID” lacks a clear definition within the spec, leading to inconsistencies among providers and challenges for practitioners in aligning cost and usage data with external sources, such as pricing APIs. This item addresses those ambiguities.
Level of Effort Required: Medium — Clarifying the SKU ID definition is a relatively straightforward task but needs coordination with providers to ensure uniform understanding and application.
Level of Impact: Medium – Clear SKU ID definitions enable consistent alignment of cost and usage data across provider APIs, directly affecting the accuracy of financial reporting and integration with external pricing data, which is crucial for practitioners.

@jpradocueva jpradocueva moved this from Parking Lot to W.I.P in FOCUS WG Nov 5, 2024
@jpradocueva jpradocueva modified the milestones: v1.1, v1.2 Nov 5, 2024
@jpradocueva
Copy link
Contributor

Comments from the Members' call on November 7:

#314: The group continued to work on classifying SKU properties, deciding to narrow down the focus to essential elements. Due to time constraints, an additional meeting was proposed to finalize which elements could be included in v1.2.

@jpradocueva
Copy link
Contributor

Action Items from TF-3 call on Nov 8:

  • [#314] Task Force: Refine the definitions of SKU ID and SKU Price ID to resolve ambiguities.

@shawnalpay shawnalpay added the 1.2 Agreed scope for release 1.2 label Nov 18, 2024
@jpradocueva
Copy link
Contributor

jpradocueva commented Nov 26, 2024

Summary from the Maintainers' call on Nov 25

Context:
The purpose is to ensure that SKU IDs are clearly defined in the specification, addressing confusion about their usage and scope.
Maintainers Assigned:
Michael, Irena, Karl, Riley
Task Force Assigned:
Task Force 2 (TF2).

Next Steps from the TF-2 call on November 27:

  • [#314] Irena @ijurica , Michael @flanakin : Collect existing provider mappings and definitions for SKU ID and SKU Price ID, including details on tiering, effective dates, and unit pricing.
  • [#314] Michael @flanakin : Review internal Microsoft data and provide examples of SKU ID and SKU Price ID mappings to help refine definitions.
  • [#314] David: Provide feedback on GCP’s usage of SKU ID and SKU Price ID, highlighting any discrepancies or challenges.
  • [#314] Task Force: Schedule a focused discussion in the next TF3 meeting to review proposed definitions and provider mappings.
  • [#314] All Members: Provide input on whether additional properties should be included to address provider-specific nuances (e.g., regional or tier data).
  • [#314] Karl @flanakin : Share insights on how SKUs and pricing are handled in the retail industry to guide the clarification process.
  • [#314] Irena @ijurica : Prepare a draft of the clarified definitions for SKU ID and SKU Price ID for initial review before the next TF3 meeting.

@shawnalpay shawnalpay removed the 1.2 consideration To be considered for release 1.2 label Nov 27, 2024
@jpradocueva
Copy link
Contributor

jpradocueva commented Dec 6, 2024

Action Items from the TF-2 Meeting on December 4:

  • [#314] Karl @kk09v : Publish a poll to propose a few 1-hour time slots for next week to discuss #314: Clarify the Definition of SKU ID. Include the regular TF-2 meeting as one of the options.
  • [#314] Joaquin @jpradocueva : Add the decision on the time slot to discuss #314 as a topic in the Maintainers Meeting agenda.
  • [#314] Maintainers: Based on the poll results, decide on the meeting time at the next Maintainers Meeting - whether to schedule an ad-hoc meeting or allocate 1 hour during the next TF-2 meeting. This decision should also account for other complex TF-2 topics, such as backwards compatibility.
  • [#314] Karl @kk09v : Share insights on how SKUs and pricing are handled in the retail industry at the ad-hoc meeting or next TF-2 meeting.
  • [#314] Michael @flanakin : Review internal Microsoft data and provide examples of SKU ID and SKU Price ID mappings to help refine definitions. (Carried over from the previous meeting.)
  • [#314] David: Provide feedback on GCP’s usage of SKU ID and SKU Price ID, highlighting any discrepancies or challenges. (Carried over from the previous meeting.)

Action Items from the Members' call on December 5.

@jpradocueva
Copy link
Contributor

Action Items from the TF-2 call on December 11:

  • [#314] Group: Categorize SKU-related properties into buckets for SKU ID and SKU Price ID.

@shawnalpay shawnalpay moved this from Parking Lot to W.I.P in FOCUS WG Dec 12, 2024
@jpradocueva
Copy link
Contributor

Action Items from the Maintainers' call on December 16:

  • [#314] Michael @flanakin : Cross-check the survey options and ensure all classification buckets are accurately represented in the spreadsheet Irena has created.

@jpradocueva
Copy link
Contributor

Action Items from the Maintainers' call on Jan 6:

@jpradocueva
Copy link
Contributor

Action Items from the TF-2 call on Jan 8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2 Agreed scope for release 1.2 csp Cloud service providers sku details Attributes related to the SKU entity spec revision Revise existing definition to be clearer or more accurate work item Issues to be considered for spec development
Projects
Status: W.I.P
9 participants