-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Work_Item] Clarify definition of SKU ID #314
Comments
Questions:
|
I believe providers should define SKUs as different types of usage, meaningful from a DevOps perspective (i.e. can be monitored), to which additional dimensions might be added to define the price, like |
The problem I have is that I don't know what a "SKU" is for FOCUS. It's not clear as a provider what I should set the value to. And if I don't know, I'm pretty sure others won't either. At best, everyone will guess and we'll end up with inconsistent meanings for SkuId, which will make it meaningless. I don't think we need to require that SkuId have a specific set of attributes, but I do think we should say what it SHOULD include to make it clear what the intent is. As of right now, I could put absolutely anything in there and abide by the spec. That feels broken. |
I feel this should be part of 1.0. Right now, it's not clear what value should be used for SkuId. Am I the only one? |
I agree that SKU ID must be part of 1.0 and that its description as "a unique identifier that defines a provider-supported construct for organizing properties that are common across one or more SKU Prices" is somewhat abstract. The description of a SKU Price ID as "a unique identifier that defines the unit price used to calculate the charge" might also seem awkward, as the term SKU is part of the name, but not of the description. From the discussions that led to the current specification version, I understand that a SKU in FOCUS is in simple words what is purchased or used by a consumer, and what is charged to the consumer. This has been split in FOCUS into SKU ID (to identify the SKU) and into SKU Price ID (to identify the unit price), because a single SKU may have multiple prices, depending on other dimensions like Pricing Tier for example. Is it correct? If yes, I would propose indeed to reformulate the descriptions of SKU ID and SKU Price ID to link them more clearly to the core concept of SKU. |
As a practitioner, it is not immediately apparent to me that I would care too much about the actual SKU ID value and I could handle cross provider uniqueness by joining with Provider; however if providers can create SKU ID as something meaningful I am all for that. |
Notes from Maintainers' call on November 4:Context: The term “SKU ID” lacks a clear definition within the spec, leading to inconsistencies among providers and challenges for practitioners in aligning cost and usage data with external sources, such as pricing APIs. This item addresses those ambiguities. |
Comments from the Members' call on November 7:#314: The group continued to work on classifying SKU properties, deciding to narrow down the focus to essential elements. Due to time constraints, an additional meeting was proposed to finalize which elements could be included in v1.2. |
Action Items from TF-3 call on Nov 8:
|
Summary from the Maintainers' call on Nov 25Context: Next Steps from the TF-2 call on November 27:
|
Action Items from the TF-2 Meeting on December 4:
Action Items from the Members' call on December 5.
|
Action Items from the TF-2 call on December 11:
|
Action Items from the Maintainers' call on Jan 6:
|
Action Items from the TF-2 call on Jan 8:
|
1. Problem Statement *
As a provider, I don't know what value to use for
SkuId
. The description is not explicit enough in what the value represents. Given there are many attributes for a SKU that make it unique, the description needs to be more precise so providers know what value to use and practitioners can reliably depend on the value across providers.Use cases:
2. Objective *
Clearly describe what
SkuId
represents so it's clear to implementers.3. Supporting Documentation *
Current description:
https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/blob/working_draft/specification/columns/skuid.md
4. Proposed Solution / Approach
Needs discussion as it's never been clear what this represents.
I would like to see this mapped back to existing retail product thinking rather than trying to define something on our own. @kk09v mentioned this in a previous meeting.
5. Epic or Theme Association
TBD
6. Stakeholders *
Do you want to see this column in FOCUS?
Give it a 👍 below ↴
Comments are welcome and encouraged!
The text was updated successfully, but these errors were encountered: