Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new devtools icons #27

Closed
nt1m opened this issue Jul 9, 2018 · 10 comments
Closed

Add new devtools icons #27

nt1m opened this issue Jul 9, 2018 · 10 comments

Comments

@nt1m
Copy link
Contributor

nt1m commented Jul 9, 2018

screen shot 2018-07-09 at 18 13 02

screen shot 2018-07-09 at 18 13 09

All available at:
https://searchfox.org/mozilla-central/source/devtools/client/themes/images

@aminalhazwani
Copy link
Collaborator

Hey @nt1m! Thanks for sharing this, we believe that most of the icons look Photon but we have doubts on the Settings one: it goes in a different direction as our current settings icon https://design.firefox.com/icons/viewer/#preferences fill vs. outline. I briefly talked with Victoria - she is the designer on devtools - but she told me that someone else drew those icons. Feel free to share the issue with the person who designed those, thanks!

@nt1m
Copy link
Contributor Author

nt1m commented Jul 10, 2018

@aminalhazwani I believe that settings icon is just a 2px stroke version of the older devtools settings icon. It looks like the engineer who worked on bug 1461522 created the icons.

@nt1m
Copy link
Contributor Author

nt1m commented Jul 10, 2018

@birtles @violasong Can we simply use the photon preferences icon there as @aminalhazwani mentioned ?

@birtles
Copy link
Contributor

birtles commented Jul 11, 2018

These icons were already added in 5f2b743.

We could use the photon preferences one I guess. It's up to Victoria.

(Also, I need to update the dock to bottom icon since there was some feedback that users found it harder to scan since it has a different width to the other dock icons.)

@aminalhazwani
Copy link
Collaborator

@birtles yeah, the other piece of feedback was actually regarding the dock to bottom icon width 😉 We do also have a doorhanger icon (disable popup), not up on the icons website yet 😔

@birtles
Copy link
Contributor

birtles commented Jul 11, 2018

I filed a bug for fixing the icon width so I'll get to that sometime in the 63 Nightly cycle.

@aminalhazwani
Copy link
Collaborator

Cool! I'll try my best to put them up on the Photon Icons website!

@violasong
Copy link

Thanks Bryan, that would be great if that bottom-dock icon could have the same browser dimensions as the other icons! Not sure how I missed this before.

Re: Prefs icon: I was torn because the outlined gear icon looks so good! But using Photon's gear everywhere in DevTools does seem like the most correct thing to do.

@birtles
Copy link
Contributor

birtles commented Jul 12, 2018

Oh, one more thing, I wonder if we should use the "Open In New" icon for the "Separate window" menu item and drop the "Dock Undock" icon? @violasong Any preference?

@violasong
Copy link

@birtles Sorry for the delay in responding to this, I was unsure which icon I liked better - but I saw the 'open in new' icon in your bugzilla screenshot and it looked great! One benefit is that it looks more different from the three docking icons than the old separate window icon, which could make it easier to parse as a group, especially in row format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants