-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try swapping in fastroute #51
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
===========================================
- Coverage 97.65% 97.46% -0.2%
- Complexity 100 109 +9
===========================================
Files 17 17
Lines 299 316 +17
===========================================
+ Hits 292 308 +16
- Misses 7 8 +1
Continue to review full report at Codecov.
|
That most recent commit is currently broken, only due to some minor cleanup that needs to happen. It's directionally pretty close to the end-goal here (I think), pending some additional testing. Good news: this routing separation helps with #53 Maybe-bad news: since FastRoute handles HEAD requests as it should (see #82), we will need to forcibly add some middleware to strip the body. Shouldn't be hard, but |
The regex-capture to fastroute-capture thing is a bit weird, but it's an ok first pass
This may fix #50 to some extent as well.
Needs WAY more testing and a way to set up caching and general configuration - or at least proper integration into the build_endpoint_list stuff