Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Incompatible with comments module #169

Open
dhensby opened this issue Aug 1, 2016 · 4 comments
Open

Incompatible with comments module #169

dhensby opened this issue Aug 1, 2016 · 4 comments

Comments

@dhensby
Copy link

dhensby commented Aug 1, 2016

This module is incompatible with the https://github.com/silverstripe/silverstripe-comments module due to a class naming collision.

Perhaps this module should use the comments module as a dependency?

@Firesphere
Copy link
Owner

Yep, I noticed this as well. Just haven't gotten around to fixing it. To not make it break on backward, I was thinking on refactoring towards NewsComments or something. Adapting the Comments module is a long-term fix.

@tungdt-90
Copy link

Hi !

I was the one who raised the issue on silverstripe-comment.

In the meantime, i'm writing my own Comment object, but i would like to follow this issue, and hope that it can be fixed/merged soon.

Have good day !

@Firesphere
Copy link
Owner

Expect an update somewhere this week. I'm going to "namespace" all classes by prefixing them and add a backward compatibility build change. Stay on the stable branch please :)

@Firesphere
Copy link
Owner

Sorry it's taking so long. I'm running into some mild issues with the migration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants