-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide typing stubs #40
Comments
Let's do this. Any. preference on how you want me to approach this, a single PR or different PRs module-wise. Any other things I should keep in mind before doing it? |
@tushar5526 I think a single PR should be fine, there isn't a lot of code in this repository. The only thing that might provide a little painful is the typing of flag values but you can check the typing approaches in the flagsmith-engine repository for approaches on that - it looks like we're just using |
@tushar5526 I have set up the necessary tooling and CI here: #70 Please use the Note that the SDK supports Python 3.8 so be sure to take it into account by using e.g. |
Sure thanks! |
Should there be type hints for tests as well? |
Yes, please! |
I think this one is closed! |
Closing, released as ed535de in 3.6.0 :) |
The following is mypy output when using Flagsmith SDK in a strictly typed project:
Hopefully, shouldn't be too hard to fix. (Famous last words before jumping in the Python typing rabbit hole.)
The text was updated successfully, but these errors were encountered: