Add API for Random numbers (OS-dependent) (#14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leha-bot
changed the title
Currently POSIX-only.
leha-bot
force-pushed
the
feat/os-random
branch
from
e094458 to
fa34085
Compare
kachsheev
reviewed
Sep 13, 2024
| @@ -0,0 +1,16 @@ | |||
| #include "FlameIDE/Common/PrimitiveTypes.hpp" | |||
There was a problem hiding this comment.
Use <>. And I think this string can be removed.
| { | ||
|
|
||
|
|
||
| flame_ide::primitive_types::ssize_t RandomRange(void *buf, flame_ide::primitive_types::size_t size) |
There was a problem hiding this comment.
Use flame_ide::Types from Numbers.hpp
kachsheev
reviewed
Sep 26, 2024
| return RandomRange(&result, sizeof(T)) == sizeof(T) ? result : 0; | ||
| } | ||
|
|
||
| }} |
There was a problem hiding this comment.
Add comment to the end of namespaces
| return getrandom(buf, size, 0); | ||
| } | ||
|
|
||
| }} |
There was a problem hiding this comment.
Add comment to the end of namespaces
kachsheev
requested changes
Dec 2, 2024
| {namespace os | ||
| { | ||
|
|
||
| flame_ide::primitive_types::ssize_t RandomRange(void *buf, flame_ide::primitive_types::size_t size); |
| /// It fills all bytes of returned value. | ||
| /// @tparam T Integral type used for returned value (default is int). | ||
| template <typename T = flame_ide::primitive_types::int_t> | ||
| typename EnableType<IsIntegralValue<T>, T>::Type Random() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14 .