-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db migrations are not tracked #201
Comments
I thought they were tracked since last time rhe issue was raised. Yes good! |
@Abdur-rahmaanJ I'm not sure if you are speaking of the issue that occurred during deployment or some actual issue raised here, please reference it if there is additional information. I have tested the ability to start tracking the migrations folder locally however in doing so I see that the initialize command in the However this behavior is defined upstream in shopyo, so it appears to be an intentional choice. I would have hoped that has been resolved in more recent versions of shopyo but I see that it is not, at least on their dev branch. It appears we might be interested in the shopyo developers discussing this and determining if they have interest in pursuing the path of tracking migrations as I suggested. Otherwise perhaps we need someone to develop an alternative initialization process. |
@jtrip Ok XD Would be grateful if you can raise an issue here: https://github.com/shopyo/shopyo/issues Yes i think better we implement our own Since we are the devs of Shopyo like we appreciate the feedback a lot! |
If we generate migrations when the developer makes a change requiring one we can track them for analysis. This may also be a good idea because it encourages the developer to ensure the migration generates and works properly. This also helps avoid issue discovery at deployment.
I believe we can easily start tracking the migrations that are currently used in production to accomplish this in a safe and efficient manner.
I believe this will require an update to the readme to instruct developers in the change and perhaps some messaging on discord.
I will take a look at this tomorrow. Please let me know if you have any questions or concerns.
The text was updated successfully, but these errors were encountered: