Content height listener issue fix

Flipkart · Oct 1, 2020 · 4c9565e · 4c9565e
1 parent 557d938
commit 4c9565e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "recyclerlistview",
-  "version": "3.0.7",
+  "version": "3.0.8",
   "description": "The listview that you need and deserve. It was built for performance, uses cell recycling to achieve smooth scrolling.",
   "main": "dist/reactnative/index.js",
   "types": "dist/reactnative/index.d.ts",

diff --git a/src/core/RecyclerListView.tsx b/src/core/RecyclerListView.tsx
@@ -403,6 +403,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
     }
 
     private _checkAndChangeLayouts(newProps: RecyclerListViewProps, forceFullRender?: boolean): void {
+        const { height: oldContentHeight, width: oldContentWidth } =  this.getContentDimension();
         this._params.isHorizontal = newProps.isHorizontal;
         this._params.itemCount = newProps.dataProvider.getSize();
         this._virtualRenderer.setParamsAndDimensions(this._params, this._layout);
@@ -444,6 +445,10 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
                 this._refreshViewability();
             }
         }
+        const {height: newContentHeight, width: newContentWidth} = this.getContentDimension();
+        if (this.props.onSizeChange && (oldContentHeight !== newContentHeight || oldContentWidth !== newContentWidth)) {
+            this.props.onSizeChange(this.getRenderedSize(), this.getContentDimension());
+        }
     }
 
     private _refreshViewability(): void {
@@ -484,7 +489,6 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
                 this._refreshViewability();
             }
         }
-
         if (this.props.onSizeChange) {
             this.props.onSizeChange(this.getRenderedSize(), this.getContentDimension());
         }
@@ -619,9 +623,6 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
             }
             this._queueStateRefresh();
         }
-        if (this.props.onSizeChange) {
-            this.props.onSizeChange(this.getRenderedSize(), this.getContentDimension());
-        }
     }
 
     private _checkExpectedDimensionDiscrepancy(itemRect: Dimension, type: string | number, index: number): void {