-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: badger day update #174
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for badger-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was
linked to
issues
Jan 29, 2023
This was
linked to
issues
Jan 29, 2023
nftchance
commented
Jan 31, 2023
nftchance
commented
Feb 10, 2023
nftchance
commented
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Slither reportSummary |
…pto/badger into fix/v6-consolidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #174 rebuilds most of the foundation of the web-app to operate on the framework needed to leave the MVP phase. With this, WebSockets become integrated, followed by clean-up in the supporting areas.
We have had to handle a bit of technical debt in the beginning; thus, this PR rebuilds every piece of the app. While we knew that we would one day want WebSockets, we did not expect to change our approach in such a severe manner.
To support this, the pieces are being developed in parallel to make the:
All work together without compromise. Avoiding the typical downfall of traditional web3 app development, the on-chain team is the same as the off-chain; thus, we can secure benefits built into the product's core.
Moving forward, the technical overhead and developer onboarding are significantly lower due to the approachability and general architecture of the API and the consuming routes.
Once the app experience has been updated, the brand will also be updated in this same PR.
Nice to haves: