Merge pull request #142 from FloRul/rich_pdf_ingestion_lambda

access env var correctly
FloRul · Apr 4, 2024 · 872a5de · 872a5de
2 parents b32f403 + 17da4fe
commit 872a5de
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -36,7 +36,7 @@ jobs:
         aws ecr describe-repositories --repository-names ${{ vars.RESUME_REQUEST_PROCESSOR_ECR_NAME }} || aws ecr create-repository --repository-name ${{ vars.RESUME_REQUEST_PROCESSOR_ECR_NAME }}
         aws ecr describe-repositories --repository-names ${{ vars.RESUME_REQUEST_PREPROCESSOR_ECR_NAME }} || aws ecr create-repository --repository-name ${{ vars.RESUME_REQUEST_PREPROCESSOR_ECR_NAME }}
         aws ecr describe-repositories --repository-names ${{ vars.RESUME_ECR_NAME }} || aws ecr create-repository --repository-name ${{ vars.RESUME_ECR_NAME }}
-        aws ecr describe-repositories --repository-names $RICH_PDF_INGESTION || aws ecr create-repository --repository-name $RICH_PDF_INGESTION
+        aws ecr describe-repositories --repository-names ${{ env.RICH_PDF_INGESTION }} || aws ecr create-repository --repository-name ${{ env.RICH_PDF_INGESTION }}
 
     - name: Generate timestamp
       id: timestamp
@@ -64,8 +64,8 @@ jobs:
         docker push $ECR_REGISTRY/${{ vars.RESUME_REQUEST_PREPROCESSOR_ECR_NAME }}:$IMAGE_TAG
         docker build -t $ECR_REGISTRY/${{ vars.RESUME_ECR_NAME }}:$IMAGE_TAG ./lambdas/ResumeProcessor/ResumeFunction
         docker push $ECR_REGISTRY/${{ vars.RESUME_ECR_NAME }}:$IMAGE_TAG
-        docker build -t $ECR_REGISTRY/$RICH_PDF_INGESTION:$IMAGE_TAG ./lambdas/$RICH_PDF_INGESTION/src
-        docker push $ECR_REGISTRY/$RICH_PDF_INGESTION:$IMAGE_TAG
+        docker build -t $ECR_REGISTRY/${{ env.RICH_PDF_INGESTION }}:$IMAGE_TAG ./lambdas/${{ env.RICH_PDF_INGESTION }}/src
+        docker push $ECR_REGISTRY/${{ env.RICH_PDF_INGESTION }}:$IMAGE_TAG
 
   deploy-infra:
     if: github.event_name == 'push' && github.ref == 'refs/heads/main'
@@ -126,6 +126,5 @@ jobs:
         -var="resume_request_processor_lambda_repository_name=${{ vars.RESUME_REQUEST_PROCESSOR_ECR_NAME }}" \
         -var="resume_request_preprocessor_lambda_repository_name=${{ vars.RESUME_REQUEST_PREPROCESSOR_ECR_NAME }}" \
         -var="resume_lambda_repository_name=${{ vars.RESUME_ECR_NAME }}" \
-        -var="resume_lambda_repository_name=$RICH_PDF_INGESTION \
-
+        -var="resume_lambda_repository_name=${{ env.RICH_PDF_INGESTION }} \
         -auto-approve -no-color -input=false