Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calEnergy(mps,Vmat,para,op) is not implemented if para.useStarMPS =True #5

Open
jdelpino opened this issue Sep 8, 2016 · 2 comments

Comments

@jdelpino
Copy link
Collaborator

jdelpino commented Sep 8, 2016

Would be really appealing to add the support of this function, called from getObservable(type,mps,Vmat,para) for Star/Multichain MPS to compute many-sites ground state energies.

@FlorianASchroeder
Copy link
Owner

Sure, this can be implemented fairly quickly. In principle it should be equivalent to the lines of code used in expvCustom/STARmultA (and expvCustom/TREEmultA for TreeMPS code). We can think about separating the code into a function so that calEnergy and expvCustom can both call it. But this will also cause some minor call-overhead slowing down expvCustom a little bit (possibly not noteworthy).

@jdelpino
Copy link
Collaborator Author

jdelpino commented Sep 9, 2016

Perfect! Thank you very much.
Therefore, as far as I understand, for the StarMPS case, the energy of the last MPS after imaginary time evolution (the closest state to the ground state which is saved by default after the simulation), would be just obtained by calling STARmultA(A) where the input A is some properly reshaped vector v = {mps, Vmat, CV, C}

I think once clarified this we could indeed separate the code despite the small slowing down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants