Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orgchart library dependency to latest one #66

Closed
paodb opened this issue Apr 28, 2023 · 1 comment · Fixed by #74
Closed

Update orgchart library dependency to latest one #66

paodb opened this issue Apr 28, 2023 · 1 comment · Fixed by #74
Assignees

Comments

@paodb
Copy link
Member

paodb commented Apr 28, 2023

Currently, Orgchart Add-on is relying on a very old version of OrgChart library, 2.1.4. Checking the library repository, the latest at this moment is 3.6.0. There a few updates regarding not longer depending on the use of font-awesome for icons, some changes on the display of export button, some refactoring, dependencies updates and more.

It will be nice to make the add-on rely on a newer version and also to check if it could help to fix some identified issues this add-on is currenty presenting/causing (#65, https://github.com/FlowingCode/AddonsDemo/issues/103, #72).

@paodb
Copy link
Member Author

paodb commented Apr 28, 2023

I did a test using the latest version and I can see some changes but not significant ones, for example, if I compare the first example in the demo, in the current version of the add-on it looks like this:

orgchart-current

When updating the library sources, the export button displays on bottom, thestyling of the nodes seems better, the icons are different:

orgchart-update-test

I see some problem on the display of the Bottom to Top example:

Current:
orgchart-bottom-to-top-current

With the update:
orgchart-bottom-to-top-update-test

I still need to run more testing and see what updates are needed in the add-on (for example regarding fc-orgchart.js).

One good thing about this is that the export no longer breaks as reported in #65 but the problems reported in https://github.com/FlowingCode/AddonsDemo/issues/103 & #72 remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant