Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are not aligned with grids in horizontal orientation #174

Open
ngonzalezpazFC opened this issue Mar 20, 2024 · 5 comments
Open

Buttons are not aligned with grids in horizontal orientation #174

ngonzalezpazFC opened this issue Mar 20, 2024 · 5 comments
Labels

Comments

@ngonzalezpazFC
Copy link
Contributor

The buttons layout appears to have padding, causing it to be misaligned with the grids.
image

@mlopezFC
Copy link
Member

Can you supply more information?, is this happening if you just add it to a layout without specifying a height?

@ngonzalezpazFC
Copy link
Contributor Author

Can you supply more information?, is this happening if you just add it to a layout without specifying a height?

If no size is specified:
image
If I set full width:
image
If I set full size:
image

Tested in a vaadin starter with vaadin 24.3.9 and tcg 2.9.2

@javier-godoy
Copy link
Member

Those screenshots demonstrate #125 which was fixed in 2.9.3 (although I think it's unrelated to this issue)

@ngonzalezpazFC
Copy link
Contributor Author

Those screenshots demonstrate #125 which was fixed in 2.9.3 (although I think it's unrelated to this issue)

Thanks for showing #125 and confirming that it is fixed. Although unrelated, I wanted to demonstrate that button layout misalignment occurs regardless of component size.

@javier-godoy
Copy link
Member

Yes. It seems this <span> could use better styles.
image

    font-size: var(--lumo-font-size-s);
    margin-bottom: calc(var(--vaadin-button-margin, var(--lumo-space-xs))* -1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Do
Development

No branches or pull requests

3 participants