From bad8c71df1a712c7892861267ebb34f1c3746a11 Mon Sep 17 00:00:00 2001 From: Paola De Bartolo Date: Thu, 7 Nov 2024 15:22:13 -0300 Subject: [PATCH 1/2] docs: fix javadoc warnings Close #18 --- .../vaadin/addons/whatsappbutton/WhatsappButton.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/whatsappbutton/WhatsappButton.java b/src/main/java/com/flowingcode/vaadin/addons/whatsappbutton/WhatsappButton.java index c488c27..adc2c50 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/whatsappbutton/WhatsappButton.java +++ b/src/main/java/com/flowingcode/vaadin/addons/whatsappbutton/WhatsappButton.java @@ -99,7 +99,7 @@ public String getText() { /** * Sets an invite code. * - * @param invite code the invite code to set + * @param inviteCode the invite code to set */ public void setInviteCode(String inviteCode) { this.getElement().setProperty("invitecode", inviteCode); @@ -171,7 +171,7 @@ public boolean isResponsive() { /** * Sets responsive option. * - * @param redirect true to enable redirect + * @param responsive true to enable responsive option */ public void setResponsive(boolean responsive) { this.getElement().setProperty("responsive", responsive); @@ -190,7 +190,7 @@ public boolean isShowDialog() { * Sets dialog option. If true, a dialog will show on button click indicating whatsapp is * opening. * - * @param redirect true to enable redirect + * @param dialog true to enable dialog option */ public void setShowDialog(boolean dialog) { this.getElement().setProperty("dialog", dialog); From d33c94315226913bfe762cbda1be898bad84150a Mon Sep 17 00:00:00 2001 From: Paola De Bartolo Date: Thu, 7 Nov 2024 15:22:58 -0300 Subject: [PATCH 2/2] ci: configure Javadoc failOnWarnings Close #19 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 69b057f..cad0a8e 100644 --- a/pom.xml +++ b/pom.xml @@ -304,7 +304,7 @@ true none - false + true https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}