From 28ae35f98bf0c3f2b1988af2c80ce9cfeb5ec0f6 Mon Sep 17 00:00:00 2001 From: Iajret Creature <122297233+AnArgonianLizardThatStealsPRs@users.noreply.github.com> Date: Tue, 14 Nov 2023 11:01:36 +0300 Subject: [PATCH] [MIRROR] Allows Signers to send COMSIG_MOB_SAY [MDB IGNORE] (#24982) (#612) * Allows Signers to send COMSIG_MOB_SAY (#79677) ## About The Pull Request By removing a conditional statement which prevented signers from sending a `COMSIG_MOB_SAY` signal (for some reason), this PR fixes a few things in one go: - Sign language once again prints a notice that the signer raises or lowers their eyebrows for exclamations and questions respectively. - Tonal indicators (sign/typing icons that depict eyebrows raising or lowering) are also working again. - RuneChat is now punctuated the same as the chat box for Signers. This PR is now atomic thanks to @ MrMelbert. * Allows Signers to send COMSIG_MOB_SAY --------- Co-authored-by: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Co-authored-by: DBGit42 <149782698+DBGit42@users.noreply.github.com> --- code/modules/mob/living/living_say.dm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/code/modules/mob/living/living_say.dm b/code/modules/mob/living/living_say.dm index f4c1772721c..56d066cdcc0 100644 --- a/code/modules/mob/living/living_say.dm +++ b/code/modules/mob/living/living_say.dm @@ -190,11 +190,10 @@ GLOBAL_LIST_INIT(message_modes_stat_limits, list( last_say_args_ref = REF(args) #endif - if(!HAS_TRAIT(src, TRAIT_SIGN_LANG)) // if using sign language skip sending the say signal - // Make sure the arglist is passed exactly - don't pass a copy of it. Say signal handlers will modify some of the parameters. - var/sigreturn = SEND_SIGNAL(src, COMSIG_MOB_SAY, args) - if(sigreturn & COMPONENT_UPPERCASE_SPEECH) - message = uppertext(message) + // Make sure the arglist is passed exactly - don't pass a copy of it. Say signal handlers will modify some of the parameters. + var/sigreturn = SEND_SIGNAL(src, COMSIG_MOB_SAY, args) + if(sigreturn & COMPONENT_UPPERCASE_SPEECH) + message = uppertext(message) var/list/message_data = treat_message(message) // unfortunately we still need this message = message_data["message"]