From f4ff8e5e5043d8a7b25c2ec506546da6c81f4725 Mon Sep 17 00:00:00 2001 From: NovaBot <154629622+NovaBot13@users.noreply.github.com> Date: Tue, 19 Mar 2024 22:09:19 -0400 Subject: [PATCH] [MIRROR] Converts ore_mined talley into only recording typepaths. (#1540) * Converts ore_mined talley into only recording typepaths. (#82098) ## About The Pull Request This Pull request makes it so that the blackbox `ore_mined` talley will now only record the mineral stack's typepath as opposed to a 50/50 mix of names and typepaths. ## Why It's Good For The Game Fixes #82042. Logging should be as descriptive as possible while also avoiding the possibility for misunderstanding, so using the typepath for logging on the blackbox is preferred. ## Changelog :cl: code: Mineral logging now collects ore names more cleanly. /:cl: * Converts ore_mined talley into only recording typepaths. --------- Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> --- code/modules/mining/boulder_processing/boulder.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/mining/boulder_processing/boulder.dm b/code/modules/mining/boulder_processing/boulder.dm index 4aa7f57d8a7..796e382b21a 100644 --- a/code/modules/mining/boulder_processing/boulder.dm +++ b/code/modules/mining/boulder_processing/boulder.dm @@ -162,7 +162,7 @@ stack_trace("boulder found containing material type [picked.type] with no set ore_type") continue cracked_ore = new cracked_ore_type (drop_location(), quantity) - SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore) + SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore.type) ///Moves boulder contents to the drop location, and then deletes the boulder. /obj/item/boulder/proc/break_apart()