Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] bindable action buttons #2014

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[MIRROR] bindable action buttons #2014

merged 2 commits into from
Feb 19, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1002
Original PR: tgstation/tgstation#81371

About The Pull Request

work started 12/12/2023

you may alt-click action buttons to bind them to a key
these are subject to click cooldown and if an action successfully triggers click cooldown is triggered so you cant instantly do multiple
alt-click again to unbind

Why It's Good For The Game

moving your mouse to the top left corner to do combat is not good gameplay

Changelog

🆑 mc-oofert
qol: you may altclick action buttons to bind them to a key
/:cl:

* bindable action buttons (#81371)

you may alt-click action buttons to bind them to a key
these are subject to click cooldown and if an action successfully
triggers click cooldown is triggered so you cant instantly do multiple
alt-click again to unbind

moving your mouse to the top left corner to do combat is not good
gameplay

:cl:
qol: you may altclick action buttons to bind them to a key
/:cl:

---------

Co-authored-by: MrMelbert <[email protected]>

* bindable action buttons

---------

Co-authored-by: jimmyl <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Feb 17, 2024
@Iajret Iajret merged commit 02f5e4c into master Feb 19, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-1002 branch February 19, 2024 17:50
AnywayFarus added a commit that referenced this pull request Feb 19, 2024
Iajret pushed a commit that referenced this pull request Apr 16, 2024
* Medipens cant be deepfried anymore (#82676)

## About The Pull Request

Saltshakers and IV drips have special checks that allows edible things
through, and deepfrying medipens turns them edible, therefore opening
the exploit that you can deepfry a medipen to drain and inject chemcials
into it.
This sucks, and I don't want to get rid of this cool feature for
everyone else, so I'm just gonna go the cheap way and blacklist medipens
from being deepfried at all.
It's too much of a hassle and I don't want to have to constantly bug
smash new ways to inject/drain from edible foods just so medipens can't
be exploited as an instant piercing chem transfer.

## Why It's Good For The Game

Explained in the about me already, this is lame!

Closes tgstation/tgstation#82631, closes
tgstation/tgstation#79178

## Changelog

:cl:
fix: Medipens can no longer be deepfried, closing an exploit that
allowed people to drain/inject chems into it with saltshakers and IV
drips.
/:cl:

* Medipens cant be deepfried anymore

---------

Co-authored-by: John Willard <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 16, 2024
* Medipens cant be deepfried anymore (#82676)

## About The Pull Request

Saltshakers and IV drips have special checks that allows edible things
through, and deepfrying medipens turns them edible, therefore opening
the exploit that you can deepfry a medipen to drain and inject chemcials
into it.
This sucks, and I don't want to get rid of this cool feature for
everyone else, so I'm just gonna go the cheap way and blacklist medipens
from being deepfried at all.
It's too much of a hassle and I don't want to have to constantly bug
smash new ways to inject/drain from edible foods just so medipens can't
be exploited as an instant piercing chem transfer.

## Why It's Good For The Game

Explained in the about me already, this is lame!

Closes tgstation/tgstation#82631, closes
tgstation/tgstation#79178

## Changelog

:cl:
fix: Medipens can no longer be deepfried, closing an exploit that
allowed people to drain/inject chems into it with saltshakers and IV
drips.
/:cl:

* Medipens cant be deepfried anymore

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants