[MIRROR] Fixes spurious runtime on Icemoon caused by turf calling unimplemented LateInitialize() #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplemented LateInitialize() (#1898) * Fixes spurious runtime on Icemoon caused by turf calling unimplemented LateInitialize() (#82572) ## About The Pull Request As of tgstation/tgstation#82540 this runtime was happening,  `/turf/open/openspace/icemoon/` can be changed to `/turf/open/misc/asteroid/snow/icemoon/do_not_chasm` before `Initialize()` returns, which resulted in it `INITIALIZE_HINT_LATELOAD` getting returned on a turf that does not have an implementation of that proc. This should fix that. ## Why It's Good For The Game Fixes CI error * Fixes spurious runtime on Icemoon caused by turf calling unimplemented LateInitialize() --------- Co-authored-by: Bloop <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ed crusher (#2826) * removes the force drop when trying to attack with an unwielded crusher * Update kinetic_crusher.dm --------- Co-authored-by: necromanceranne <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1898
Original PR: tgstation/tgstation#82572
About The Pull Request
As of tgstation/tgstation#82540 this runtime was happening,
/turf/open/openspace/icemoon/can be changed to/turf/open/misc/asteroid/snow/icemoon/do_not_chasmbeforeInitialize()returns, which resulted in itINITIALIZE_HINT_LATELOADgetting returned on a turf that does not have an implementation of that proc.This should fix that.
Why It's Good For The Game
Fixes CI error