[MIRROR] Kills spec_updatehealth
, replaces it with use of COMSIG_LIVING_HEALTH_UPDATE
#766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24152
Original PR: tgstation/tgstation#78772
About The Pull Request
Quick refactor, replaces
spec_updatehealth
with use ofCOMSIG_LIVING_HEALTH_UPDATE
.spec_updatehealth
was only used by one species, ethereals, and it was used in a (in my opinion) janky way by callingspec_updatehealth
constantly.This has one downside -
COMSIG_LIVING_HEALTH_UPDATE
is NOT sent if the mob is in godmode, whilespec_updatehealth
was, which means godmoded ethereals may not update 100% accurately according to their health before entering godmode, but I doubt this will come into play often at all.Why It's Good For The Game
updatehealth
is kinda hot, not turbo hot but a little hot, so this helps performance a bit.Changelog
🆑 Melbert
refactor: Refactors how ethereals update their color when damaged.
/:cl: