Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes borers being unable to inject chemicals #781

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25195

About The Pull Request

Probably #24207 (not sure, too lazy to check) changed how global chemical list formed so it now has "Chemical Full Name" = datum/... instead of "ckeyedchemicalname" = datum/... and borers tgui addressed chemicals by their "ckeyd" id, not by proper name.

Also, i've decided to left this chemical.id variable just because it is used as an id for various buttons.

How This Contributes To The Skyrat Roleplay Experience

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 Iajret
fix: borers can once again fill their hosts with various wonders of chemistry
/:cl:

@Iajret Iajret merged commit ac9d7c0 into master Nov 23, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25195 branch November 23, 2023 09:08
AnywayFarus added a commit that referenced this pull request Nov 23, 2023
Iajret pushed a commit that referenced this pull request Feb 5, 2024
* ethereal disco ball altclick sanity (#81268)

## About The Pull Request

im getting tired of writing this but you may no longer altclick to
unanchor or anchor when crit or at range or otherwise

## Why It's Good For The Game

bug bad

## Changelog
:cl:
fix: you may no longer altclick ethereal disco balls while unconscious
to anchor/unanchor
/:cl:

* ethereal disco ball altclick sanity

---------

Co-authored-by: jimmyl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants