Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated code should not produce any lint warnings #5

Open
sgehrman opened this issue Jan 2, 2021 · 2 comments
Open

generated code should not produce any lint warnings #5

sgehrman opened this issue Jan 2, 2021 · 2 comments

Comments

@sgehrman
Copy link

sgehrman commented Jan 2, 2021

I'm seeing warnings for unnecessary parens, and prefer const in the example mapper.g.dart.

I would be great to get this fixed. I like all my code to be clean and warning free.

image

@D10100111001
Copy link
Contributor

The package has been updated for null safety. Let me know if this is still an issue. If so, I'll see if I can revisit but this is low priority so will do it when I get a chance. PRs are welcome.

@sgehrman
Copy link
Author

sgehrman commented Jun 2, 2021

I'm still having one last issue.

Try adding avoid_dynamic_calls: true

and see if you see it. There's a line in my mapper file that does something like json['x'] that needs to be (json['x'] as String)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants