From a8737d71e09dd436b864971b8c83b1478ee070e6 Mon Sep 17 00:00:00 2001 From: Michael Abbott <32575566+mcabbott@users.noreply.github.com> Date: Mon, 18 Mar 2024 16:03:10 -0400 Subject: [PATCH] Use LazyString in depwarn (#2400) * Update macro.jl * Update deprecations.jl * Update Project.toml * Update src/layers/macro.jl Co-authored-by: Lasse Peters * Update src/deprecations.jl --------- Co-authored-by: Lasse Peters --- Project.toml | 2 +- src/deprecations.jl | 4 ++-- src/layers/macro.jl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Project.toml b/Project.toml index bc31cd5d3f..660ca26296 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "Flux" uuid = "587475ba-b771-5e3f-ad9e-33799f191a9c" -version = "0.14.13" +version = "0.14.14" [deps] Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" diff --git a/src/deprecations.jl b/src/deprecations.jl index 4b094e5eb5..5acdec5455 100644 --- a/src/deprecations.jl +++ b/src/deprecations.jl @@ -196,8 +196,8 @@ end # Greek-letter keywords deprecated in Flux 0.13 # Arguments (old => new, :function, "β" => "beta") function _greek_ascii_depwarn(βbeta::Pair, func = :loss, names = "" => "") - Base.depwarn("""function $func no longer accepts greek-letter keyword $(names.first) - please use ascii $(names.second) instead""", func) + Base.depwarn(LazyString("function ", func, " no longer accepts greek-letter keyword ", names.first, """ + please use ascii """, names.second, " instead"), func) βbeta.first end _greek_ascii_depwarn(βbeta::Pair{Nothing}, _...) = βbeta.second diff --git a/src/layers/macro.jl b/src/layers/macro.jl index 2fb6db0faf..ab6f6ae867 100644 --- a/src/layers/macro.jl +++ b/src/layers/macro.jl @@ -89,7 +89,7 @@ end function _check_new_macro(x::T) where T Functors.isleaf(x) && return - Base.depwarn("This type should probably now use `Flux.@layer` instead of `@functor`: $T", Symbol("@functor")) + Base.depwarn(LazyString("This type should probably now use `Flux.@layer` instead of `@functor`: ", T), Symbol("@functor")) end _check_new_macro(::Tuple) = nothing # defined by Functors.jl, not by users _check_new_macro(::NamedTuple) = nothing