-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some v0.13 deprecations #2493
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2493 +/- ##
==========================================
- Coverage 41.26% 38.92% -2.35%
==========================================
Files 37 37
Lines 2118 2063 -55
==========================================
- Hits 874 803 -71
- Misses 1244 1260 +16 ☔ View full report in Codecov by Sentry. |
Docs CI error is not related to this PR and will be fixed in #2492. |
Should we update https://github.com/FluxML/Flux.jl/blob/master/.buildkite/pipeline.yml too? Relatedly, should we modify https://github.com/FluxML/Flux.jl/blob/master/.github/workflows/nightly-ci.yml to test on |
remove v0.13 deprecations reinsert optimisers add 1.9 CI drop julia v1.9
2cac684
to
6b45e21
Compare
I kept |
ready to go! |
Remove v0.13 deprecations except for the old optimizers, which require more care and a separate PR.
This also