Bump Metalhead to 0.9 - making CUDA optional #240
Conversation
|
It seems nightly tests fail due to a CUDA issue. It's most likely not related to this PR. Re-triggering the tests on the dev branch can confirm this. |
|
Once this PR is approved and merged, I would appreciate a quick release. |
|
It seems that tests are running out of time. I am trying to run them locally but they also take forever. |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #240 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 12 12
Lines 316 316
=======================================
Hits 291 291
Misses 25 25 ☔ View full report in Codecov by Sentry. |
|
Tests pass now. |
There was a problem hiding this comment.
Thanks @mohamed82008 for this PR and your patience for a review.
I agree a breaking release is better safe than sorry, so current version update is good.
I see that CI (at least the GH action) only has testing for latest julia version. Can we add 1.9, since 1.10 is around the corner?
Co-authored-by: Anthony Blaom, PhD <[email protected]>
The latest version which is currently tested is Julia 1.9. We also test nightly here which is more bleeding edge than 1.10. I don't understand your comment. |
|
The CI on nightly is failing for the same reason it fails on the current dev #241. I think it is a CUDA-nightly issue so should not be blocking. |
|
I meant add 1.9 to the matrix here, which now would mean duplicate testing. But I guess we can add that later. I'll create an issue. |
This PR bumps Metalhead to v0.9 which makes CUDA an optilonal dependency. Given the discussion in FluxML/Metalhead.jl#253, I also bumped the major version of MLJFlux in the process. Please let me know if you prefer to make this a patch release and support both Metalhead 0.8 and 0.9.