-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for convolution on N-dimensions #213
Comments
No need for a separate keyword. We can just remove the Most of the work here is removing the type restrictions and adding tests to make sure it works with dimensions other than 2D. |
Hi @darsnack,
unit test. It Failed with error
|
Did you also update the corresponding |
Yup I tried that as well :) |
Motivation and description
ndim
parameter in convx layers LinkSee :
https://github.com/FluxML/FastAI.jl/blob/505621985c27f0d988086345eb44ce7074611173/FastVision/src/models/xresnet.jl#L4
Possible Implementation
Adding N dim kernels for flux layers (eg conv_norm, basic_conv_bn ...)
Reason : Metalhead's unet adaptation from FastAI.jl uses Metalhead's prebuilt layers like those mentioned above and residual blocks like basicblocks, and these do not have option to specify the number of dimensions of input. They have been developed to keep just 2d images in mind thus 2d kernel.
ndim would enable kernels of multi dimension images.
Metalhead.jl/src/layers/conv.jl
Line 29 in 80ab995
.. see Dims{2}
The text was updated successfully, but these errors were encountered: