remove 1.6 CI

FluxML · Nov 8, 2024 · 5ea9e76 · 5ea9e76
1 parent cc5cc4e
commit 5ea9e76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,9 +15,9 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - '1.6'
           - '1'
           - 'nightly'
+          - "1.10"
         os:
           - ubuntu-latest
         arch:

diff --git a/ext/OptimisersEnzymeCoreExt.jl b/ext/OptimisersEnzymeCoreExt.jl
@@ -52,7 +52,8 @@ function update!(opt_state, model_grad::Duplicated)
   nothing
 end
 
-# This function strips the returned gradient to be Zygote-like:
+# This function strips the returned gradient to be Zygote-like,
+# most importantly prune=nothing removes 2nd appearance of shared gradient to avoid double-counting.
 _grad_or_nothing(dup::Duplicated) = fmapstructure(_grad_or_nothing, dup.dval; prune=nothing)
 _grad_or_nothing(::Const) = nothing
 _grad_or_nothing(x) = isnumeric(x) ? x : nothing