Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what could we do while ssr-prepass and renderToNodeStream #47

Closed
sayjeyhi opened this issue Apr 2, 2020 · 2 comments
Closed

what could we do while ssr-prepass and renderToNodeStream #47

sayjeyhi opened this issue Apr 2, 2020 · 2 comments
Labels
question Further information is requested

Comments

@sayjeyhi
Copy link

sayjeyhi commented Apr 2, 2020

There is a gap between we are waiting to ssrPrepass(element) finish (api calls finish) and renderToNodeStream which increase TTFB, is there any idea about doing sth in this gap.

for example if we could get helmet needs data and stream header before finishing the whole ssr-prepass promise..
@kitten
Copy link
Contributor

kitten commented Apr 2, 2020

So if you don’t have a lot of async tasks you can also try out react-lightyear: https://github.com/Ephem/react-lightyear

It only does a single render pass but comes with other caveats. It will reduce TTFB but that will only be useful depending on where your suspense boundary is.

It may be worth though for you to look into CDN caching if possible, since that’ll always have the greatest impact.

A middle ground may be to move the entire schema execution into the SSR server. That could have event loop implications as your SSR server does more work, but since you’ll execute the schema in the same process, you also have more in-memory caching options. (That depends on this package being shipped urql-graphql/urql#474)

So overall you have several options but they really depend more on your architecture and on finding small workarounds since this is inherently an issue with SSR :)

@kitten kitten added the question Further information is requested label Apr 2, 2020
@sayjeyhi
Copy link
Author

sayjeyhi commented Apr 3, 2020

Thank you dear @kitten, actually I take a look at react-lightyear and give it a try, I see it is not the thing I am looking for. Specially using throw to handle api call suspense, gets a little bit complicated redux or saga.

I see react-ssr-prepass is doing better my tasks. I got an idea and it improved my TTFB, I write html head with main js and css file to be preloaded, it decreased my TTFB to 100ms. In other hand it helped me to preload my main js file parallel with prepassing SSR needs api calls.

const statsFile = path.resolve(
    `./build/loadable-stats.json`,
);
const chunkExtractor = new ChunkExtractor({ statsFile });
const { stats } = chunkExtractor;

res.set({ 'content-type': 'text/html; charset=utf-8' });
res.write('<!doctype html><html lang="fa"><head>
<link rel="preload" href="${stats.assetsByChunkName.main}" as="script" />
<script async src="${stats.assetsByChunkName.main}" ></script>
');

Maybe some one asks about handling 404,301 cuz I am writing data on response before deciding about route existence or redirection, for that purpose I used matchPath from react-router-dom so I can predict them.

@sayjeyhi sayjeyhi closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kitten @sayjeyhi