Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add a lot more test coverage. #207

Open
ryan-roemer opened this issue Oct 10, 2017 · 3 comments
Open

Tests: Add a lot more test coverage. #207

ryan-roemer opened this issue Oct 10, 2017 · 3 comments
Assignees
@ElreyB
Labels
Feature Request
Milestone
3.0

Comments

@ryan-roemer
Copy link
Member

No description provided.

@ryan-roemer ryan-roemer mentioned this issue Oct 10, 2017
Merged
ryan-roemer added a commit that referenced this issue Oct 10, 2017
@ryan-roemer
Add basic tests. (#208)
c9be427 
* Fixes #205 
* Add the most minimal skeleton tests to import most files and check for rudimentary breakage.
* Make `bin/webpack-dashboard.js` exportable in addition to being a script.
* Follow-on real test ticket at #207 
* Update eslintrc to use `arrow-parens: [error, as-needed]`
@kenwheeler kenwheeler added this to the 2.0 milestone Jan 15, 2018
@ryan-roemer ryan-roemer modified the milestones: 2.0, 3.0 May 24, 2018
@parkerziegler
Copy link
Contributor

@ryan-roemer @ElreyB is taking awesome initiative on this ticket. Is there anything in particular you'd like him to focus on with tests (either between the plugin or the UI itself)? Any guidance here would be great 🎉

@ryan-roemer
Copy link
Member Author

@ElreyB -- ping me next week and hopefully we can chat! (I'll be back next week)

@parkerziegler
Copy link
Contributor

parkerziegler commented Oct 10, 2018 •
edited
Loading

@ryan-roemer Latest coverage summary after merging @ElreyB's PR:

============ Coverage summary ================
Statements   : 37.8% ( 144/381 )
Branches     : 43.03% ( 71/165 )
Functions    : 18.87% ( 20/106 )
Lines        : 38.48% ( 142/369 )
===========================================

So still some way to go, but it's getting there. Going to leave this issue open as a tracking place for test PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElreyB ElreyB

Labels
Feature Request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
4 participants
@kenwheeler @ryan-roemer @parkerziegler @ElreyB