Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JANUS unit tests #31

Open
lsoucasse opened this issue Jul 10, 2024 · 4 comments
Open

JANUS unit tests #31

lsoucasse opened this issue Jul 10, 2024 · 4 comments
Labels
enhancement New feature or request JOSS publication: PROTEUS TBD before JOSS publication Priority 2: high Priority level 2: high time criticality or importance Unit tests Unit tests across the PROTEUS ecosystem

Comments

@lsoucasse
Copy link
Member

The tests we have for now are global examples and we might think of breaking those into smaller pieces so that it makes bugs easier to track.

@stefsmeets
Copy link
Contributor

The current tests take about 7 minutes on my system, which is too long too be useful. I think not only splitting them up, but also making a smaller test data set that runs in a shorter amount of time (couple of seconds) would be nice.

@stefsmeets
Copy link
Contributor

stefsmeets commented Jul 22, 2024

One cycle of instellation alone takes 45 seconds, and the code does 7 cycles 😅

@stefsmeets
Copy link
Contributor

It's not entirely clear how the test can be broken into smaller pieces, it's mostly lots of setup, a few lines of code, and then clean-up. What we can do is parametrize the tests. I'm going to have a go at this to get a bit of a feel for the code.

@stefsmeets stefsmeets self-assigned this Jul 22, 2024
@stefsmeets stefsmeets removed their assignment Aug 12, 2024
@nichollsh
Copy link
Contributor

It would be good if any tests of JANUS use different platforms or distributions. We are more likely to catch issues such as: FormingWorlds/MORS#22

@timlichtenberg timlichtenberg added Priority 2: high Priority level 2: high time criticality or importance JOSS publication: PROTEUS TBD before JOSS publication Unit tests Unit tests across the PROTEUS ecosystem labels Nov 19, 2024
@timlichtenberg timlichtenberg changed the title Create unit tests for Janus JANUS unit tests Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JOSS publication: PROTEUS TBD before JOSS publication Priority 2: high Priority level 2: high time criticality or importance Unit tests Unit tests across the PROTEUS ecosystem
Projects
Status: JOSS Publication
Development

No branches or pull requests

4 participants