Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set hydrogen inventory by concentration #287

Closed
nichollsh opened this issue Nov 22, 2024 · 1 comment
Closed

Set hydrogen inventory by concentration #287

nichollsh opened this issue Nov 22, 2024 · 1 comment
Assignees
@nichollsh
Labels
enhancement New feature or request JOSS publication: PROTEUS TBD before PROTEUS JOSS publication outgassing Physics - outgassing and vapourisation Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation

Comments

@nichollsh
Copy link
Contributor

Currently we specify hydrogen inventory in absolute terms of equivalent numbers of Earth oceans. Other volatiles (S, N, C) are set in relative terms.

This means that for fixed volatile delivery parameters, less massive planets will end up receiving relatively more hydrogen than more massive planets. As a result, comparing planets in the same system becomes difficult when they have different masses.

It would be ideal if we could set the hydrogen inventory of the planet in relative terms too. This will require minor changes to both PROTEUS and CALLIOPE.
@nichollsh nichollsh added enhancement New feature or request JOSS publication: PROTEUS TBD before PROTEUS JOSS publication outgassing Physics - outgassing and vapourisation Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation labels Nov 22, 2024
@nichollsh nichollsh self-assigned this Nov 22, 2024
@nichollsh nichollsh moved this to JOSS Publication in PROTEUS Development Roadmap Nov 22, 2024
@nichollsh
Copy link
Contributor Author

Closed by #292.

@github-project-automation github-project-automation bot moved this from In Progress to Done in PROTEUS Development Roadmap Nov 27, 2024
@nichollsh nichollsh mentioned this issue Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nichollsh nichollsh

Labels
enhancement New feature or request JOSS publication: PROTEUS TBD before PROTEUS JOSS publication outgassing Physics - outgassing and vapourisation Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation
Projects
PROTEUS Development Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nichollsh