Convert focusable attribute to boolean from string (#42)

FortAwesome · Feb 6, 2020 · 348ae41 · 348ae41
1 parent 97fa749
commit 348ae41
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/dist/converter.js b/dist/converter.js
@@ -56,6 +56,10 @@ function convert(createElement, element) {
         delete element.attributes[key];
         break;
 
+      case "focusable":
+        acc.attrs[key] = Boolean(val);
+        break;
+
       default:
         if (key.indexOf('aria-') === 0 || key.indexOf('data-') === 0 || 'fill' === key && 'currentColor' === val) {
           delete element.attributes[key];

diff --git a/src/components/__tests__/FontAwesomeIcon.test.js b/src/components/__tests__/FontAwesomeIcon.test.js
@@ -188,4 +188,17 @@ describe('when extra props are given', () => {
   })
 })
 
-
+describe("convert focusable attribute", () => {
+  test("from false string to boolean", () => {
+    const tree = renderer
+      .create(<FontAwesomeIcon icon={faCoffee} focusable='false' color="purple" foo="bar" />)
+      .toJSON();
+    expect(tree.props.focusable).toEqual(false);
+  });
+  test("from true string to boolean", () => {
+    const tree = renderer
+      .create(<FontAwesomeIcon icon={faCoffee} focusable='true' color="purple" foo="bar" />)
+      .toJSON();
+    expect(tree.props.focusable).toEqual(true);
+  });
+});
diff --git a/src/converter.js b/src/converter.js
@@ -32,6 +32,9 @@ function convert(createElement, element, extraProps = {}) {
         case 'xmlns':
           delete element.attributes[key]
           break
+        case "focusable":
+          acc.attrs[key] = Boolean(val);
+          break
         default:
           if (key.indexOf('aria-') === 0 || key.indexOf('data-') === 0 || ( 'fill' === key && 'currentColor' === val )) {
             delete element.attributes[key]