Remove "Recycle bin" feature

[naveensingh]

Checklist

• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the request will be dismissed otherwise.
• This issue contains only one feature request.
• I have read and understood the contribution guidelines.

Feature description

Remove the recycle bin feature.

Why do you want this feature?

The feature should be removed because:

• It only works with individual messages, not whole conversations.
• Adding support for deleting conversations would turn this feature into the "Archive" feature and we'll have two things doing the same with different names.
• Simpler code base, less potential for bugs.

Additional information

This might be a breaking change for some/many so it should probably be a part of version 2.0.0.

Related:

• Moving items into Recycle Bin is not working #174 (comment)
• https://www.reddit.com/r/Fossify/comments/1i9e1wa/unable_to_move_messages_into_recycle_bin/

The archive feature is simple and enough for most use-cases, we could optionally add a 'Automatically delete archived messages after 30 days' option for those who want it to act like a recycle bin.

[s38b35M5]

I would just ask to confirm that this message is correct before putting my full support behind this feature.

Disregard

[MGidnian]

Will it retain the functionality of "archiving" a single message and not the whole conversation?

I see how for some conversations you would like to completely archive/hide the conversation.
But another use case is: for many services/business - a common blocking use case it that you will get relevant messages (OTP, updates, etc) but will also get ads and other irrelevant messages in the same conversation.

To keep things clean and relevant - the best case scenario is to be able to archive/block/hide only certain messages but keep the rest in the inbox.

This functionality is supported today by the recycle bin, and also makes much sense for the keyword blocking mechanism in general.

[naveensingh]

Will it retain the functionality of "archiving" a single message and not the whole conversation?

No but keyword blocking + #59 should solve such usecases.