Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] read only #69

Open
6 of 7 tasks
throwaway242685 opened this issue Sep 26, 2024 · 9 comments
Open
6 of 7 tasks

[fr] read only #69

throwaway242685 opened this issue Sep 26, 2024 · 9 comments
Labels
feature request Issue is about a new feature in the app

Comments

@throwaway242685
Copy link

throwaway242685 commented Sep 26, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

hi, it would be great if this app had an option/button to individually set notes as "read-only'.

Why do you want this feature?

I personally save text to use/copy later on these notes, and I don't want to accidentally overwrite the text on these notes when I tap on them.

this would be different than locking the note in the sense that you would still see the text being displayed (with the possibility to select and copy it), but you wouldn't be able to edit it.

Additional information

(Notepad++ also has a "read-only" option, just to name an example)

@throwaway242685 throwaway242685 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Sep 26, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Sep 26, 2024
@vbernier02
Copy link

Hello,

I am a third-year computer science student at the University. As part of a course of free software development, i would like to work on this feature for my first contribution.

@throwaway242685
Copy link
Author

throwaway242685 commented Jan 28, 2025

yeah, sure, go ahead.

I'm sure both Aga-C and naveensingh will be okay with that.

I actually had some ideas for this.

what do you think about implementing a new "lock" button that would put the note to "read-only" and viceversa?

something like this:

Screenshot_2025-01-28_05-18-31_1.png Screenshot_2025-01-28_05-18-31_1.png

@Aga-C
Copy link
Member

Aga-C commented Jan 28, 2025

@throwaway242685 This icon is currently used for locked notes. We can't use this icon in another context because it will be misleading for users.

@throwaway242685
Copy link
Author

throwaway242685 commented Jan 28, 2025

I meant at the top, as a small icon, next to the others.

any other icon design with the same function should be okay, I guess.

@vbernier02
Copy link

Hi, for the feature i'm thinking of keeping the project's approach and adding it to the options menu, similar to the "lock note" feature.
I was thinking like, pressing the option will lock the writing on the note and you will have to return to the option to unlock it.
I'll keep the idea in mind for an icon.

@naveensingh
Copy link
Member

Actually, let's wait a bit until we have a better idea on how to approach this. I do not like the menu button idea.

@naveensingh naveensingh added the needs triage Issue is not yet ready for PR authors to take up label Jan 28, 2025
@throwaway242685
Copy link
Author

throwaway242685 commented Jan 28, 2025

well, if it eventually comes down to a button:

screenshot_20250128-080134.png

I was thinking that it should be placed at the top left corner, separated from the rest of the icons.

that way is less prone to misclick, or pick the wrong button.

and, it's more visible :-)

btw... about the icon, is this a more suitable choice?

1.png
2.png

perhaps the hitbox (the detection area) should be a bit larger, tho... considering its small size.

@naveensingh
Copy link
Member

I was thinking that it should be placed at the top left corner, separated from the rest of the icons.

That's not the right place for it and it's reserved for the back button, see #27

I do not like the menu button idea.

@vbernier02

I am not happy with it but if you are up for it, let's do it. You can check Material Notes for reference. The final icons depend on the text, here's some examples:

(I like Enter preview mode because then we won't need another button for #22)

The Create a new note action button should probably be moved back into the overflow menu because we are already breaking the rule with 5 existing buttons:

@naveensingh naveensingh removed the needs triage Issue is not yet ready for PR authors to take up label Jan 28, 2025
@vbernier02
Copy link

I am not happy with it but if you are up for it, let's do it.

Thanks, I'll work on it. I'll try to do it with the icons you suggested for now. If it seems better, we can put the feature in the overflow menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants