From 88514302ae99429c39d91884389be49d831114a0 Mon Sep 17 00:00:00 2001 From: Tyrone Tudehope Date: Wed, 4 Dec 2019 07:51:41 +0200 Subject: [PATCH] Character limit on line item name field --- CHANGELOG.md | 1 + src/services/Xml.php | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 958e243..901a38c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ## Updated - Replaced use of deprecated adjustment functions, `getAdjustmentsTotalByType`. +- Return maximum of 200 characters for the line item `Name` field. ## 1.2.5 - 2019-11-25 diff --git a/src/services/Xml.php b/src/services/Xml.php index 210709b..9a97aab 100644 --- a/src/services/Xml.php +++ b/src/services/Xml.php @@ -186,9 +186,15 @@ public function item(\SimpleXMLElement $xml, LineItem $item, $name='Item') 'SKU' => [ 'callback' => function ($item) { return $item->snapshot['sku']; - } + }, + 'cdata' => false, + ], + 'Name' => [ + 'callback' => function ($item) { + return substr($item->description, 0, 200); + }, + 'cdata' => false, ], - 'Name' => 'description', 'Weight' => [ 'callback' => function ($item) { $weight_units = CommercePlugin::getInstance()->settings->weightUnits;