Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue in JWT 5.4.0 #41

Open
alensiljak opened this issue Feb 20, 2024 · 6 comments
Open

Security issue in JWT 5.4.0 #41

alensiljak opened this issue Feb 20, 2024 · 6 comments

Comments

@alensiljak
Copy link

Hi!
The Jwt 5.4.0 is flagged as a security risk by SonarQube. It is used by Microsoft.AzureServiceBus.

image

Upgrading JWT to at least 5.7.0 would fix this.

@alensiljak
Copy link
Author

alensiljak commented Feb 20, 2024

😱

image

Do you have plans on updating the dependencies?

@niemyjski
Copy link
Member

Hello,

We'd be willing to accept any pr's to update this.

@alensiljak
Copy link
Author

Microsoft.Azure.ServiceBus is deprecated so it's a bit of a bigger issue than just a PR.

https://www.nuget.org/packages/Microsoft.Azure.ServiceBus

image

@niemyjski
Copy link
Member

We need to get the azure libs updated and it's on our list (pr would be very grateful if you have some time). Problem is they keep coming out with a completely new package of which seems yearly and the one after this one had crazy management libraries, they've since removed due to pushback.

@alensiljak
Copy link
Author

Thanks for the feedback! I'd like to help but, as usual, it's a matter of availability of time.
I'm waiting for some guidelines on how to proceed.

@alensiljak
Copy link
Author

The quickest solution to this particular issue is to force a (currently) safe version of Jwt by adding

<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="5.7.0" />

to the project file. So, no pressure for now, until some other vulnerability is identified. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants