Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating tests for unterminated quoted string error when backslash is… #92

Conversation

avillarrealRW
Copy link

… at the end of the data

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@niemyjski
Copy link
Member

Thanks for the pr! @ejsmith can you please take a look into this.

@ejsmith
Copy link
Contributor

ejsmith commented Dec 21, 2024

Finally looked into this. Sorry it took so long.

This test is invalid. C# interprets that string as "something\" which is escaping the quote and therefore causes an error saying it's an unterminated quoted string.

@niemyjski
Copy link
Member

Thanks for the PR, sorry it took so long. I'm closing this as @ejsmith debugged and pointed out its correct behavior. Please let us know if you any questions.

@niemyjski niemyjski closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants