Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Metrics.Net with AppMetrics #114

Open
edwardmeng opened this issue Jan 3, 2018 · 5 comments
Open

Replace Metrics.Net with AppMetrics #114

edwardmeng opened this issue Jan 3, 2018 · 5 comments
Labels
Hacktoberfest Hacktoberfest

Comments

@edwardmeng
Copy link
Contributor

The library Metrics.Net is only available for netfx and only can be deployed on windows servers. But the Foundatio currently supports netstandard 2.0, the Metrics.Net should be replaced with AppMetrics which supports netstandard, so that we can deployed on linux or unix.

@ejsmith
Copy link
Contributor

ejsmith commented Jan 3, 2018

@edwardmeng I agree. I have been wanting to make some changes to the Foundatio metrics contract to allow adding tags/dimensions to metrics and I also wanted to create an AppMetrics implementation as well.

@niemyjski
Copy link
Member

They are working on a metrics.net net standard implementation and it was user contribed (on a side note). I also agree with the both of you but against removing metrics.net :)

@ejsmith
Copy link
Contributor

ejsmith commented Jan 3, 2018

Wouldn't remove it. Would just add another implementation.

@edwardmeng
Copy link
Contributor Author

@ejsmith I am wondering how to support tags/dimensions for statsd implementation. As I know the statsd does not support it be default.

@ejsmith
Copy link
Contributor

ejsmith commented Jan 8, 2018

Sorry for the late reply @edwardmeng. Yeah, there are some implementations that would not be able to to support tagging/dimensions. So those would just be ignored. I am envisioning that we just add a method to let you create scopes that contain the dimensions on them and they just return the normal IMetricsClient back so none of the core contract would change. It would just be a matter of adding a method like this:

public interface IMetricsClient : IDisposable {
   IMetricsClient BeginScope(IDictionary<string, object> data);
   void Counter(string name, int value = 1);
   void Gauge(string name, double value);
   void Timer(string name, int milliseconds);
}

Then we would have extension methods with a fluent builder that let you build up the scope dictionary using a fluent lambda syntax which would be used something like this:

using (var scoped = client.StartScope(s => s.Tag("mytag").Dimension("host", "myhost1"))) {
  scoped.Counter("mycounter");
}

Tags would just be added to the dictionary without any values. We could also add extension methods for the Counter, Gauge, Timer methods that let you add scope data to individual metrics by just wrapping the method in a BeginScope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants