Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review configureSidecarContainer #2179

Open
johscheuer opened this issue Nov 29, 2024 · 0 comments
Open

Review configureSidecarContainer #2179

johscheuer opened this issue Nov 29, 2024 · 0 comments
Labels
technical-debt

Comments

@johscheuer
Copy link
Member

What would you like to be added/changed?

Currently the configureSidecarContainer is a bit hard to read with the different cases (depending on the passed optional cluster and if the sidecar is configured for backups). We should review this method and see if we can simplify some things to make it easier to reason about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johscheuer