Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup pods should make use of the fdbmonitor/fdb-kubernetes-monitor to start processes #2193

Open
johscheuer opened this issue Jan 20, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@johscheuer
Copy link
Member

What would you like to be added/changed?

Currently the operator creates a deployment to manage the backup agents as a Kubernetes Deployment. In this deployment the backup_agent process is directly started. This has a few drawbacks, e.g. the backup_agent will run as PID 1 and not listen on signals, which makes it impossible to kill the process (and the signal for a graceful shutdown will be ignored). To prevent this we should use the monitor process to start the backup_agent, otherwise the handling of the deployment strategy should be through the Kubernetes Deployment controller.

@johscheuer johscheuer added the enhancement New feature or request label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant