Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS ja4/ja4x binaries? #154

Open
Squiblydoo opened this issue Aug 29, 2024 · 1 comment
Open

MacOS ja4/ja4x binaries? #154

Squiblydoo opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Squiblydoo
Copy link
Contributor

Squiblydoo commented Aug 29, 2024

Hello!
Is there a reason for not building the ja4 and ja4x binaries for MacOS? I was unable to find past discussion regarding this.

I built the binaries in my own fork by uncommenting two lines in the existing workflow:

          - { os: macos-latest, target: x86_64-apple-darwin }
          - { os: macos-latest, target: aarch64-apple-darwin }

Because they aren't signed, I needed to first run them using the "Gatekeeper bypass" (command key + right click > "open" > hit "OK"). However, they seemed to work as I expected in my initial tests.

Is there something else I am missing in regards to why FoxIO doesn't compile them already? Or maybe it is just because of the signing issue?

Cheers.

@john-althouse john-althouse added the enhancement New feature or request label Sep 27, 2024
@igr001-galactica igr001-galactica assigned vvv and unassigned noeltimothy Sep 27, 2024
vvv added a commit to vvv/ja4 that referenced this issue Sep 28, 2024
Bump Rust apps version (0.18.3 -> 0.18.4) to give the `release` CI job
an opportunity to run.

Related issue: FoxIO-LLC#154
@vvv
Copy link
Collaborator

vvv commented Sep 30, 2024

@Squiblydoo Initially the Rust apps (ja4 and ja4x) were developed in a closed repository. We did build unsigned macOS binaries there, but that drained our CI/CD minutes quickly and I commented those YAML lines out.

But this repository is public. Meaning that its usage of GitHub-hosted runners is free:

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners.

Re signing of macOS binaries, I for one don't have the bandwidth to jump into this particular rabbit hole. Fortunately, as you've correctly determined, we can easily provide unsigned macOS binaries — it's a matter of uncommenting 2 lines of code. I've submitted PR #174 that does just that.

Thanks for raising this issue!

igr001-galactica pushed a commit that referenced this issue Sep 30, 2024
Bump Rust apps version (0.18.3 -> 0.18.4) to give the `release` CI job
an opportunity to run.

Related issue: #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants