Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REL-114] Execute local subscription dispatch synchronously #5

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

koudelka
Copy link
Contributor

Execute local subscription dispatch synchronously.

There's a lot more work that needs doing, this is just a short-term emergency fix to reign in the unbounded concurrency.

@koudelka koudelka force-pushed the mikes/synchronous-local-dispatch branch from c8d845b to a8de84c Compare June 11, 2024 23:56
Copy link
Contributor

@michaelcaterisano michaelcaterisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in preview and working as expected. We'll need to smoke test in dev too, specifically asset uploads.

@LisyCat
Copy link

LisyCat commented Jun 12, 2024

@michaelcaterisano @koudelka is this the kind of change we should ask QA / load testing script to try to put some load on before it goes live? Or are we not concerned with that.

@michaelcaterisano
Copy link
Contributor

michaelcaterisano commented Jun 12, 2024

@michaelcaterisano @koudelka is this the kind of change we should ask QA / load testing script to try to put some load on before it goes live? Or are we not concerned with that.

I think so, specifically batch asset uploads, which to my knowledge is the operation that results in the largest amount of subscription events being processed and sent out. Pretty sure that has to be tested in dev tho, so perhaps we should plan to temporarily merge to dev and test there.

That said, we're using tags with this fork, so this can be merged and we can create a tag and point to it when we're ready.

@koudelka koudelka merged commit 518f29e into main Jun 13, 2024
8 checks passed
@koudelka koudelka deleted the mikes/synchronous-local-dispatch branch June 13, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants