Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features for Preferences #158

Open
2 of 3 tasks
Gajenthran opened this issue Feb 26, 2019 · 7 comments
Open
2 of 3 tasks

New features for Preferences #158

Gajenthran opened this issue Feb 26, 2019 · 7 comments
Labels
enhancement/request Suggestion for new features or improvements UI Related to the User Interface

Comments

@Gajenthran
Copy link
Contributor

Gajenthran commented Feb 26, 2019

Hello,
Here is some new features to add in Preferences (I placed them in order of importance (in my opinion) :

  • Change language
  • Add a light/white theme (there is already a dark theme)
  • Key bindings (configuration to add new shortcuts)
    Modify the size of font (small/large) 

I don't think if there is an option to change the language but I would like to know how we can change the language otherwise.

@FrancescoCeruti FrancescoCeruti added enhancement/request Suggestion for new features or improvements UI Related to the User Interface labels Feb 27, 2019
@FrancescoCeruti
Copy link
Owner

  • Change language -> 👍 Right now is possible via a command line argument
  • Add a light/white theme -> 👍 It was there before, but it was simply one the default qt styles, it needs some adjustment or a few widgets will look bad or not display properly
  • Key bindings -> 👍 as said before it require some effort
  • Modify the size of font -> 😕 In my opinion we should rely on the OS settings, which QT already does, unless there is some convincing reason not to

@Gajenthran
Copy link
Contributor Author

Gajenthran commented Feb 27, 2019

  • Change language -> 👍 Right now is possible via a command line argument

Can I know the command, please ? Because I tried to search arguments for the language but I didn't find it.
I have these options:

usage: linux-show-player [-h] [-f [FILE]] [-l {debug,info,warning}] [--locale LOCALE]

Thanks for the reply.

@FrancescoCeruti
Copy link
Owner

Yes, sorry 😄

It's actually the --locale option, for example linux-show-player --locale it will use the italian translations.
❓ why locale? https://en.wikipedia.org/wiki/Locale_(computer_software)

Consider that beside the source language (english -> en) in the develop version there are many untranslated strings, if you're interested you can se at https://crowdin.com/project/linux-show-player the current situation

@Gajenthran
Copy link
Contributor Author

Yes, sorry 😄

It's actually the --locale option, for example linux-show-player --locale it will use the italian translations.
❓ why locale? https://en.wikipedia.org/wiki/Locale_(computer_software)

Thanks for the command and the explanation !

Consider that beside the source language (english -> en) in the develop version there are many untranslated strings, if you're interested you can se at https://crowdin.com/project/linux-show-player the current situation

Yes, I wanted to ask you about that because I saw that you modify i18n folder and there is some "unfinished" string. I will surely do that (especially french translation) !

@FrancescoCeruti
Copy link
Owner

FrancescoCeruti commented Feb 27, 2019

Yes, I wanted to ask you about that because I saw that you modify i18n folder and there is some "unfinished" string. I will surely do that (especially french translation) !

Nice, it would be great if you could do that directly form crowdin itself, you can log using your GitHub account, and the changes are pushed to l10n_develp branch on this repository, if you need to look at them.

Also for discuss on translation #38 can be a good place 😄

@Buggitt
Copy link

Buggitt commented Jul 13, 2024

Was a light theme ever added? Found the setting in preferences but only have dark as an option.

@FrancescoCeruti
Copy link
Owner

No, we still don't have a light theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/request Suggestion for new features or improvements UI Related to the User Interface
Projects
None yet
Development

No branches or pull requests

3 participants