Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImportDeclaration::importedSymbols on-demand #2015

Open
oxisto opened this issue Jan 31, 2025 · 0 comments
Open

Update ImportDeclaration::importedSymbols on-demand #2015

oxisto opened this issue Jan 31, 2025 · 0 comments
Labels

Comments

@oxisto
Copy link
Member

oxisto commented Jan 31, 2025

Currently, we issue ImportDeclaration::updateImportedSymbols for all import declarations in the import resolver and once the type resolver runs. This a) misses out on eventual future declaration updates (as implemented in #2006) and b) is very inefficient, because we only need to update those import declarations that point to a namespace where we change things (in either its scope or child-scopes).

So instead, we should update the symbols on-demand, which probably means that we need a graph edge from the import declaration to the namespace (and back).

@oxisto oxisto added the core label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant